[Lldb-commits] [PATCH] D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 7 00:48:04 PST 2020


labath added a comment.

I am having second thoughts about the image list approach to testing this. The regex matching is somewhat messy.

A bad load address should manifest itself in plenty of other ways.. Could we print the value of some global variable to check that we got the correct one?



================
Comment at: lldb/test/API/commands/process/attach/TestProcessAttach.py:94
+
+        self.runCmd("process attach -p " + str(popen.pid))
+
----------------
Do you need to attach at any particular moment during the process startup? The attach command could run pretty quickly, before the loader finished its work...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92264/new/

https://reviews.llvm.org/D92264



More information about the lldb-commits mailing list