[Lldb-commits] [PATCH] D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform

Wed Dec 2 15:20:00 PST 2020

aprantl added inline comments.

================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformRemoteMacOSX.cpp:129
+                                                           ArchSpec &arch) {
+#if defined(__arm__) || defined(__arm64__) || defined(__aarch64__)
+  // macOS for ARM64 support both native and translated x86_64 processes
----------------
Given that this is the *remote* platform — does this #if even make sense?

================
Comment at: lldb/test/API/commands/platform/sdk/TestPlatformSDK.py:20
+    # The port used by debugserver.
+    PORT = 54637
+
----------------
What happens if two tests run at the same time?

================
Comment at: lldb/test/API/commands/platform/sdk/TestPlatformSDK.py:26
+    # system.
+    TIMEOUT = 2
+
----------------
2 seconds timeout is definitely not enough for an asan bot. Can this be closer to 20s? Perhaps the result of reading `target.process.utility-expression-timeout`?

================
Comment at: lldb/test/API/commands/platform/sdk/TestPlatformSDK.py:90
+        # Give debugserver time to attach.
+        time.sleep(self.TIMEOUT)
+
----------------
I guess there is no way of implementing this without sleeping? Maybe a loop with 10 smaller sleeps?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92452/new/

https://reviews.llvm.org/D92452