[Lldb-commits] [PATCH] D92510: [lldb] set created function decl to public access in TypeSystemClang

[Raphael Isemann via Phabricator via lldb-commits]

teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.

D85993 <https://reviews.llvm.org/D85993> was trying to do the same thing and contains some explanation why I think this isn't a good solution. TL;DR is that functions in a record should call `TypeSystemClang::AddMethodToCXXRecordType` instead. Moving the `isRecord` check you add here to the PDB parser code and then calling `AddMethodToCXXRecordType` depending on whether the check is true/false is one way to fix this properly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92510/new/

https://reviews.llvm.org/D92510