[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Nov 29 23:57:44 PST 2020


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

I was just asking for comments on the two constructors, but having them elsewhere is nice too.



================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.h:29-31
+    // This class is used to restrict the range of ports that
+    // platform created debugserver/gdbserver processes will
+    // communicate on.
----------------
This looks like a class-level comment. Could you also say a few words about what the constructor does specifically.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91634/new/

https://reviews.llvm.org/D91634



More information about the lldb-commits mailing list