[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 26 04:06:40 PST 2020


DavidSpickett marked 6 inline comments as done.
DavidSpickett added inline comments.


================
Comment at: lldb/tools/lldb-server/lldb-platform.cpp:234
       if (ch == 'P')
-        gdbserver_portmap[portnum] = LLDB_INVALID_PROCESS_ID;
+        gdbserver_portmap.AllowPort(static_cast<uint16_t>(portnum));
       else if (ch == 'm')
----------------
labath wrote:
> Why the cast?
Me misreading a warning I think, removed here and below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91634/new/

https://reviews.llvm.org/D91634



More information about the lldb-commits mailing list