[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Yeah, I don't think it's possible to write a reliable end-to-end test for this feature. A unit test might be an option -- I don't know how hard it would be to mock the parts needed (starting a debug server). One could also consider refactoring this code to avoid the usage of a valid port number to represent the "no port" state (and while doing so, making the code easier to unit test).

While I would encourage you to try some of these things out, I wouldn't say that that's really required for this bugfix.

BTW, the --min/max-gdbserver-port is a constant source of bug reports (last one was last weel --  I'll have to reply to that one) and ideally I'd just do away with it. It just leaves a bad FTP taste in the mouth..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91634/new/

https://reviews.llvm.org/D91634