[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

I have found existing tests that launch an lldb-server with specific arguments, using an existing lldb-server platform to do it.

The ideal test would be:

- run lldb-server with min port some known to be available port, max is that +1
- connect the client
- send qLaunchGDBServer twice, expect that the second one has an E response

What I can't work out how to do is decide which ports you'd need to use for the `--min/max-gdbserver-port` options. I couldn't find a way to predict what ports would be
available before you launch the lldb-server. Or guarantee that any ports that were available wouldn't get used up in the time between you finding them and launching the new lldb-server.

You have to give lldb-server at least one port number to use so giving it none and expecting error doesn't work.
Giving it a port you know is already used doesn't help either, since this code would still say it's available but then fail connect to it.

So presented without a test (and the most minimal code change). Ideas welcome though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91634/new/

https://reviews.llvm.org/D91634