[Lldb-commits] [PATCH] D90875: [lldb] [test] Avoid double negatives in llgs/debugserver logic

[Michał Górny via Phabricator via lldb-commits]

mgorny marked 2 inline comments as done.
mgorny added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:950
+    configuration.llgs_platform = (
+        target_platform in ["linux", "freebsd", "netbsd", "windows"])
+
----------------
labath wrote:
> This is not entirely equivalent to the previous version -- it won't match "platforms" like "freebsd4.7". Fortunately, we already have some canonicalization code in `lldbplatformutil.getPlatform()`, so if you switch to that, it should be fine.
Good catch! However, this doesn't seem to work:

```
Command Output (stderr):
--
Traceback (most recent call last):
  File "/home/mgorny/llvm-project/llvm/tools/lldb/test/API/dotest.py", line 7, in <module>
    lldbsuite.test.run_suite()
  File "/usr/home/mgorny/llvm-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 855, in run_suite
    from lldbsuite.test import lldbplatformutil
  File "/usr/home/mgorny/llvm-project/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py", line 19, in <module>
    import lldb
ModuleNotFoundError: No module named 'lldb'

--
```

There is apparently some obscure problem behind the scenes and it seems above my pay grade. I'll just revert to the old code.


================
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:953
+    # Perform debugserver tests on Darwin platforms.  Currently, this
+    # means all platform that do not use LLGS but additional platforms
+    # may be excluded in the future.
----------------
labath wrote:
> mgorny wrote:
> > @labath, can we assume that all future platforms will use LLGS?
> I certainly hope so. I doubt anyone would port debugserver to another os, and I definitely would not want to carry another debugserver around.
Ok, I will remove the comment about adding more platforms then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90875/new/

https://reviews.llvm.org/D90875