[Lldb-commits] [PATCH] D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests

[Michał Górny via Phabricator via lldb-commits]

mgorny created this revision.
mgorny added reviewers: labath, emaste, krytarowski.
mgorny requested review of this revision.

Make the comment indicate more strongly that this behavior
is Darwin-specific and it is not a bug for other platforms to behave
differently.


https://reviews.llvm.org/D90876

Files:
  lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py
  lldb/test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py


Index: lldb/test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py
===================================================================
--- lldb/test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py
+++ lldb/test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py
@@ -25,8 +25,8 @@
         self.build()
         self.recursive_inferior_crashing_step_after_break()
 
-    # Inferior exits after stepping after a segfault. This is working as
-    # intended IMHO.
+    # A test for Darwin-specific behavior.  On other platforms, inferior
+    # exits after stepping after a segfault.
     @skipIf(oslist=["freebsd", "linux", "netbsd"])
     def test_recursive_inferior_crashing_expr_step_and_expr(self):
         """Test that lldb expressions work before and after stepping after a crash."""
Index: lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py
===================================================================
--- lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py
+++ lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py
@@ -49,8 +49,8 @@
         self.build()
         self.inferior_crashing_step_after_break()
 
-    # Inferior exits after stepping after a segfault. This is working as
-    # intended IMHO.
+    # A test for Darwin-specific behavior.  On other platforms, inferior
+    # exits after stepping after a segfault.
     @skipIf(oslist=["freebsd", "linux", "netbsd"])
     def test_inferior_crashing_expr_step_and_expr(self):
         """Test that lldb expressions work before and after stepping after a crash."""


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90876.303238.patch
Type: text/x-patch
Size: 1716 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201105/dc3ebf93/attachment.bin>