[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 5 04:00:18 PST 2020


mgorny marked 2 inline comments as done.
mgorny added inline comments.


================
Comment at: lldb/test/API/tools/lldb-server/thread-name/TestGdbRemoteThreadName.py:32
     @skipIfWindows # the test is not updated for Windows.
+    @expectedFailureAll(oslist=["freebsd"])
     @llgs_test
----------------
labath wrote:
> mgorny wrote:
> > labath wrote:
> > > What's up with this? I though you fixed thread names already..
> > The test code is buggy. I want to fix it separately not to mix things up too much.
> Fixing it here is not a good idea, yes. But I think it would have been good to fix in the patch that was implementing thread name support.
I'm planning to run the test suite a lot more once this lands, and we have more predictable results.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90757/new/

https://reviews.llvm.org/D90757



More information about the lldb-commits mailing list