[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 4 23:56:01 PST 2020


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks ok to me. I'll leave it to you to sort out the specific annotations on individual tests.



================
Comment at: lldb/test/API/tools/lldb-server/thread-name/TestGdbRemoteThreadName.py:32
     @skipIfWindows # the test is not updated for Windows.
+    @expectedFailureAll(oslist=["freebsd"])
     @llgs_test
----------------
mgorny wrote:
> labath wrote:
> > What's up with this? I though you fixed thread names already..
> The test code is buggy. I want to fix it separately not to mix things up too much.
Fixing it here is not a good idea, yes. But I think it would have been good to fix in the patch that was implementing thread name support.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90757/new/

https://reviews.llvm.org/D90757



More information about the lldb-commits mailing list