[Lldb-commits] [PATCH] D90664: [crashlog] Move crash log parsing into its own class
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Nov 2 20:58:59 PST 2020
clayborg added inline comments.
================
Comment at: lldb/examples/python/crashlog.py:708
+ crash_log_paser = CrashLogParser(crash_log_file, options.verbose)
+ crash_log = crash_log_parser.parse()
+ except Exception as e:
----------------
clayborg wrote:
> or this line can be:
> ```
> crash_log = CrashLogParser(crash_log_file, options.verbose).parse()
> ```
might be nice to test this somehow since this would have failed has this change gone through.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90664/new/
https://reviews.llvm.org/D90664
More information about the lldb-commits
mailing list