[Lldb-commits] [PATCH] D90664: [crashlog] Move crash log parsing into its own class

[Greg Clayton via Phabricator via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Looks good, just fix typo I mentioned in inlined comments.



================
Comment at: lldb/examples/python/crashlog.py:707
+        try:
+            crash_log_paser = CrashLogParser(crash_log_file, options.verbose)
+            crash_log = crash_log_parser.parse()
----------------
crash_log_parser


================
Comment at: lldb/examples/python/crashlog.py:708
+            crash_log_paser = CrashLogParser(crash_log_file, options.verbose)
+            crash_log = crash_log_parser.parse()
+        except Exception as e:
----------------
or this line can be:
```
crash_log = CrashLogParser(crash_log_file, options.verbose).parse()
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90664/new/

https://reviews.llvm.org/D90664