[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

[Med Ismail Bennani via Phabricator via lldb-commits]

mib accepted this revision.
mib added a comment.

LGTM provided that you address my last comments :)

Also, please make sure that your patch is well formatted (`git clang-format HEAD~`) before submitting it.

Thanks.



================
Comment at: lldb/include/lldb/Symbol/Type.h:111-114
   // Since Type instances only keep a "SymbolFile *" internally, other classes
   // like TypeImpl need make sure the module is still around before playing
   // with
   // Type instances. They can store a weak pointer to the Module;
----------------
Can you change this to be `///` (triple slash) Doxygen-style comments please ?


================
Comment at: lldb/include/lldb/Symbol/Type.h:117-120
+  // GetModule may return module for compile unit's object file.
+  // GetExeModule returns module for executable object file that contains
+  // compile unit where type was actualy defined.
+  // GetModule and GetExeModule may return the same value.
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88483/new/

https://reviews.llvm.org/D88483