[Lldb-commits] [PATCH] D89383: [lldb] Correct vFile:pread/pwrite packet docs

[David Spickett via Phabricator via lldb-commits]

DavidSpickett created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
DavidSpickett requested review of this revision.
Herald added a subscriber: JDevlieghere.

The statement that lldb-server can handle
decimal and hex numbers is misleading.
(it can only handle hex with 0x prefix)

Mentioning non decimal numbers at all
is just creating more confusion for anyone
who tries to use them with lldb-server.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89383

Files:
  lldb/docs/lldb-platform-packets.txt


Index: lldb/docs/lldb-platform-packets.txt
===================================================================
--- lldb/docs/lldb-platform-packets.txt
+++ lldb/docs/lldb-platform-packets.txt
@@ -416,7 +416,6 @@
 //    The gdb-remote serial protocol documentation says that numbers
 //    in "vFile:" packets should be hexidecimal. Instead lldb uses
 //    decimal for the number of bytes and offset.
-//    lldb-server can process either format.
 
 
 //----------------------------------------------------------------------
@@ -440,7 +439,7 @@
 //  COMPATIBILITY
 //    The gdb-remote serial protocol documentation says that numbers
 //    in "vFile:" packets should be hexidecimal. Instead lldb uses
-//    decimal for the offset. lldb-server can process either format.
+//    decimal for the offset.
 
 
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89383.298111.patch
Type: text/x-patch
Size: 808 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201014/42f5ed5d/attachment.bin>