[Lldb-commits] [PATCH] D89315: [debugserver] Add option to propagate SIGSEGV to target process

[Alessandro Arzilli via Phabricator via lldb-commits]

aarzilli updated this revision to Diff 298077.
aarzilli added a comment.

> I wonder if the implementation would be less intrusive (and keep some of these functions from adding to their already too many arguments) if you added this flag to the RNBContext that RNBRemote holds onto.

Done.

> You might even get away with treating this as a launch flavor (which it sort of is), though to do that you'd have to make the launch flavor OR-able which might be more work than its worth.

I'm not familiar enough with the codebase to do this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89315/new/

https://reviews.llvm.org/D89315

Files:
  lldb/tools/debugserver/source/DNB.cpp
  lldb/tools/debugserver/source/DNB.h
  lldb/tools/debugserver/source/MacOSX/MachProcess.h
  lldb/tools/debugserver/source/MacOSX/MachProcess.mm
  lldb/tools/debugserver/source/MacOSX/MachTask.h
  lldb/tools/debugserver/source/MacOSX/MachTask.mm
  lldb/tools/debugserver/source/RNBContext.h
  lldb/tools/debugserver/source/RNBRemote.cpp
  lldb/tools/debugserver/source/debugserver.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89315.298077.patch
Type: text/x-patch
Size: 18887 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201014/b78612cc/attachment-0001.bin>