[Lldb-commits] [PATCH] D89315: [debugserver] Add option to propagate SIGSEGV to target process

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

The return from a SIGSEGV or SIGILL has less information than the equivalent exception, so reporting the exceptions should be the default, but having a switch for people who need the exception to propagate is okay.

I wonder if the implementation would be less intrusive (and keep some of these functions from adding to their already too many arguments) if you added this flag to the RNBContext that RNBRemote holds onto.  You'll still have to pass it down to the Mach layers by hand, but maybe you could do less work handing it from call to call.  RNBContext has other related flags, so this seems a natural extension.

You might even get away with treating this as a launch flavor (which it sort of is), though to do that you'd have to make the launch flavor OR-able which might be more work than its worth.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89315/new/

https://reviews.llvm.org/D89315