[Lldb-commits] [lldb] d83cd73 - [lldb] [Process/FreeBSD] Mark methods override in RegisterContext*
Michał Górny via lldb-commits
lldb-commits at lists.llvm.org
Sat Oct 10 09:56:15 PDT 2020
Author: Michał Górny
Date: 2020-10-10T18:52:23+02:00
New Revision: d83cd73e9ddf9ba4cc5754560ef9a2abaaa30749
URL: https://github.com/llvm/llvm-project/commit/d83cd73e9ddf9ba4cc5754560ef9a2abaaa30749
DIFF: https://github.com/llvm/llvm-project/commit/d83cd73e9ddf9ba4cc5754560ef9a2abaaa30749.diff
LOG: [lldb] [Process/FreeBSD] Mark methods override in RegisterContext*
Differential Revision: https://reviews.llvm.org/D89181
Added:
Modified:
lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.h
lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h
lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_powerpc.h
lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.h
Removed:
################################################################################
diff --git a/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h b/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
index 906926fd9194..bb455841dff1 100644
--- a/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
+++ b/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
@@ -20,13 +20,13 @@ class RegisterContextPOSIXProcessMonitor_arm : public RegisterContextPOSIX_arm,
std::unique_ptr<RegisterInfoPOSIX_arm> register_info);
protected:
- bool ReadGPR();
+ bool ReadGPR() override;
- bool ReadFPR();
+ bool ReadFPR() override;
- bool WriteGPR();
+ bool WriteGPR() override;
- bool WriteFPR();
+ bool WriteFPR() override;
// lldb_private::RegisterContext
bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
@@ -35,39 +35,39 @@ class RegisterContextPOSIXProcessMonitor_arm : public RegisterContextPOSIX_arm,
const lldb_private::RegisterValue &value);
bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
- lldb_private::RegisterValue &value);
+ lldb_private::RegisterValue &value) override;
bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
- const lldb_private::RegisterValue &value);
+ const lldb_private::RegisterValue &value) override;
- bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp);
+ bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
- bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp);
+ bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
- bool write);
+ bool write) override;
- bool ClearHardwareWatchpoint(uint32_t hw_index);
+ bool ClearHardwareWatchpoint(uint32_t hw_index) override;
- bool HardwareSingleStep(bool enable);
+ bool HardwareSingleStep(bool enable) override;
// POSIXBreakpointProtocol
- bool UpdateAfterBreakpoint();
+ bool UpdateAfterBreakpoint() override;
- unsigned GetRegisterIndexFromOffset(unsigned offset);
+ unsigned GetRegisterIndexFromOffset(unsigned offset) override;
- bool IsWatchpointHit(uint32_t hw_index);
+ bool IsWatchpointHit(uint32_t hw_index) override;
- bool ClearWatchpointHits();
+ bool ClearWatchpointHits() override;
- lldb::addr_t GetWatchpointAddress(uint32_t hw_index);
+ lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
- bool IsWatchpointVacant(uint32_t hw_index);
+ bool IsWatchpointVacant(uint32_t hw_index) override;
bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
- bool write, uint32_t hw_index);
+ bool write, uint32_t hw_index) override;
- uint32_t NumSupportedHardwareWatchpoints();
+ uint32_t NumSupportedHardwareWatchpoints() override;
private:
RegisterInfoPOSIX_arm::GPR m_gpr_arm;
diff --git a/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.h b/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.h
index 579fa9d8cebb..dcae1d46de9b 100644
--- a/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.h
+++ b/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.h
@@ -21,13 +21,13 @@ class RegisterContextPOSIXProcessMonitor_arm64
std::unique_ptr<RegisterInfoPOSIX_arm64> register_info);
protected:
- bool ReadGPR();
+ bool ReadGPR() override;
- bool ReadFPR();
+ bool ReadFPR() override;
- bool WriteGPR();
+ bool WriteGPR() override;
- bool WriteFPR();
+ bool WriteFPR() override;
// lldb_private::RegisterContext
bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
@@ -36,39 +36,39 @@ class RegisterContextPOSIXProcessMonitor_arm64
const lldb_private::RegisterValue &value);
bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
- lldb_private::RegisterValue &value);
+ lldb_private::RegisterValue &value) override;
bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
- const lldb_private::RegisterValue &value);
+ const lldb_private::RegisterValue &value) override;
- bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp);
+ bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
- bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp);
+ bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
- bool write);
+ bool write) override;
- bool ClearHardwareWatchpoint(uint32_t hw_index);
+ bool ClearHardwareWatchpoint(uint32_t hw_index) override;
- bool HardwareSingleStep(bool enable);
+ bool HardwareSingleStep(bool enable) override;
// POSIXBreakpointProtocol
- bool UpdateAfterBreakpoint();
+ bool UpdateAfterBreakpoint() override;
- unsigned GetRegisterIndexFromOffset(unsigned offset);
+ unsigned GetRegisterIndexFromOffset(unsigned offset) override;
- bool IsWatchpointHit(uint32_t hw_index);
+ bool IsWatchpointHit(uint32_t hw_index) override;
- bool ClearWatchpointHits();
+ bool ClearWatchpointHits() override;
- lldb::addr_t GetWatchpointAddress(uint32_t hw_index);
+ lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
- bool IsWatchpointVacant(uint32_t hw_index);
+ bool IsWatchpointVacant(uint32_t hw_index) override;
bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
- bool write, uint32_t hw_index);
+ bool write, uint32_t hw_index) override;
- uint32_t NumSupportedHardwareWatchpoints();
+ uint32_t NumSupportedHardwareWatchpoints() override;
private:
RegisterInfoPOSIX_arm64::GPR m_gpr_arm64; // 64-bit general purpose registers.
diff --git a/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h b/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h
index a482cd3f1e1c..432bfdc97402 100644
--- a/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h
+++ b/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h
@@ -22,13 +22,13 @@ class RegisterContextPOSIXProcessMonitor_mips64
lldb_private::RegisterInfoInterface *register_info);
protected:
- bool ReadGPR();
+ bool ReadGPR() override;
- bool ReadFPR();
+ bool ReadFPR() override;
- bool WriteGPR();
+ bool WriteGPR() override;
- bool WriteFPR();
+ bool WriteFPR() override;
// lldb_private::RegisterContext
bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
@@ -37,39 +37,39 @@ class RegisterContextPOSIXProcessMonitor_mips64
const lldb_private::RegisterValue &value);
bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
- lldb_private::RegisterValue &value);
+ lldb_private::RegisterValue &value) override;
bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
- const lldb_private::RegisterValue &value);
+ const lldb_private::RegisterValue &value) override;
- bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp);
+ bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
- bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp);
+ bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
- bool write);
+ bool write) override;
- bool ClearHardwareWatchpoint(uint32_t hw_index);
+ bool ClearHardwareWatchpoint(uint32_t hw_index) override;
- bool HardwareSingleStep(bool enable);
+ bool HardwareSingleStep(bool enable) override;
// POSIXBreakpointProtocol
- bool UpdateAfterBreakpoint();
+ bool UpdateAfterBreakpoint() override;
- unsigned GetRegisterIndexFromOffset(unsigned offset);
+ unsigned GetRegisterIndexFromOffset(unsigned offset) override;
- bool IsWatchpointHit(uint32_t hw_index);
+ bool IsWatchpointHit(uint32_t hw_index) override;
- bool ClearWatchpointHits();
+ bool ClearWatchpointHits() override;
- lldb::addr_t GetWatchpointAddress(uint32_t hw_index);
+ lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
- bool IsWatchpointVacant(uint32_t hw_index);
+ bool IsWatchpointVacant(uint32_t hw_index) override;
bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
- bool write, uint32_t hw_index);
+ bool write, uint32_t hw_index) override;
- uint32_t NumSupportedHardwareWatchpoints();
+ uint32_t NumSupportedHardwareWatchpoints() override;
private:
uint64_t
diff --git a/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_powerpc.h b/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_powerpc.h
index 17b649feebf1..328db4479ce6 100644
--- a/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_powerpc.h
+++ b/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_powerpc.h
@@ -24,17 +24,17 @@ class RegisterContextPOSIXProcessMonitor_powerpc
protected:
bool IsVMX();
- bool ReadGPR();
+ bool ReadGPR() override;
- bool ReadFPR();
+ bool ReadFPR() override;
- bool ReadVMX();
+ bool ReadVMX() override;
- bool WriteGPR();
+ bool WriteGPR() override;
- bool WriteFPR();
+ bool WriteFPR() override;
- bool WriteVMX();
+ bool WriteVMX() override;
// lldb_private::RegisterContext
bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
@@ -43,39 +43,39 @@ class RegisterContextPOSIXProcessMonitor_powerpc
const lldb_private::RegisterValue &value);
bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
- lldb_private::RegisterValue &value);
+ lldb_private::RegisterValue &value) override;
bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
- const lldb_private::RegisterValue &value);
+ const lldb_private::RegisterValue &value) override;
- bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp);
+ bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
- bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp);
+ bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
- bool write);
+ bool write) override;
- bool ClearHardwareWatchpoint(uint32_t hw_index);
+ bool ClearHardwareWatchpoint(uint32_t hw_index) override;
- bool HardwareSingleStep(bool enable);
+ bool HardwareSingleStep(bool enable) override;
// POSIXBreakpointProtocol
- bool UpdateAfterBreakpoint();
+ bool UpdateAfterBreakpoint() override;
- unsigned GetRegisterIndexFromOffset(unsigned offset);
+ unsigned GetRegisterIndexFromOffset(unsigned offset) override;
- bool IsWatchpointHit(uint32_t hw_index);
+ bool IsWatchpointHit(uint32_t hw_index) override;
- bool ClearWatchpointHits();
+ bool ClearWatchpointHits() override;
- lldb::addr_t GetWatchpointAddress(uint32_t hw_index);
+ lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
- bool IsWatchpointVacant(uint32_t hw_index);
+ bool IsWatchpointVacant(uint32_t hw_index) override;
bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
- bool write, uint32_t hw_index);
+ bool write, uint32_t hw_index) override;
- uint32_t NumSupportedHardwareWatchpoints();
+ uint32_t NumSupportedHardwareWatchpoints() override;
private:
ProcessMonitor &GetMonitor();
diff --git a/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.h b/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.h
index c9dc02a88e01..1afb366eeba3 100644
--- a/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.h
+++ b/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.h
@@ -22,13 +22,13 @@ class RegisterContextPOSIXProcessMonitor_x86_64
lldb_private::RegisterInfoInterface *register_info);
protected:
- bool ReadGPR();
+ bool ReadGPR() override;
- bool ReadFPR();
+ bool ReadFPR() override;
- bool WriteGPR();
+ bool WriteGPR() override;
- bool WriteFPR();
+ bool WriteFPR() override;
// lldb_private::RegisterContext
bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
@@ -37,39 +37,39 @@ class RegisterContextPOSIXProcessMonitor_x86_64
const lldb_private::RegisterValue &value);
bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
- lldb_private::RegisterValue &value);
+ lldb_private::RegisterValue &value) override;
bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
- const lldb_private::RegisterValue &value);
+ const lldb_private::RegisterValue &value) override;
- bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp);
+ bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
- bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp);
+ bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
- bool write);
+ bool write) override;
- bool ClearHardwareWatchpoint(uint32_t hw_index);
+ bool ClearHardwareWatchpoint(uint32_t hw_index) override;
- bool HardwareSingleStep(bool enable);
+ bool HardwareSingleStep(bool enable) override;
// POSIXBreakpointProtocol
- bool UpdateAfterBreakpoint();
+ bool UpdateAfterBreakpoint() override;
- unsigned GetRegisterIndexFromOffset(unsigned offset);
+ unsigned GetRegisterIndexFromOffset(unsigned offset) override;
- bool IsWatchpointHit(uint32_t hw_index);
+ bool IsWatchpointHit(uint32_t hw_index) override;
- bool ClearWatchpointHits();
+ bool ClearWatchpointHits() override;
- lldb::addr_t GetWatchpointAddress(uint32_t hw_index);
+ lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
- bool IsWatchpointVacant(uint32_t hw_index);
+ bool IsWatchpointVacant(uint32_t hw_index) override;
bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
- bool write, uint32_t hw_index);
+ bool write, uint32_t hw_index) override;
- uint32_t NumSupportedHardwareWatchpoints();
+ uint32_t NumSupportedHardwareWatchpoints() override;
private:
ProcessMonitor &GetMonitor();
More information about the lldb-commits
mailing list