[Lldb-commits] [PATCH] D88841: [intel pt] Refactor parsing

[walter erquinigo via Phabricator via lldb-commits]

wallace updated this revision to Diff 297075.
wallace added a comment.

- Added “trace schema all”, following the pattern from "trace <command> all", and added a test for this.
- Created a non-static version of GetSchema in Trace.h
- Cannot delete Trace() {}, as there’s a compilation error. Could be because some constructors have been marked as deleted, so the compiler wants explicit declarations.
- Created the lldb_private::trace_intel_pt namespace
- Deleted all unnecessary namespace and “using namespace” usages.
- Using StringRef more ubiquitously now and other small fixes requested by Pavel


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88841/new/

https://reviews.llvm.org/D88841

Files:
  lldb/include/lldb/Core/PluginManager.h
  lldb/include/lldb/Target/Trace.h
  lldb/include/lldb/Target/TraceSessionFileParser.h
  lldb/include/lldb/Target/TraceSettingsParser.h
  lldb/include/lldb/lldb-forward.h
  lldb/include/lldb/lldb-private-interfaces.h
  lldb/source/Commands/CommandObjectTrace.cpp
  lldb/source/Core/PluginManager.cpp
  lldb/source/Plugins/Trace/intel-pt/CMakeLists.txt
  lldb/source/Plugins/Trace/intel-pt/ThreadIntelPT.cpp
  lldb/source/Plugins/Trace/intel-pt/ThreadIntelPT.h
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSessionFileParser.cpp
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSessionFileParser.h
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSettingsParser.cpp
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSettingsParser.h
  lldb/source/Target/CMakeLists.txt
  lldb/source/Target/Trace.cpp
  lldb/source/Target/TraceSessionFileParser.cpp
  lldb/source/Target/TraceSettingsParser.cpp
  lldb/test/API/commands/trace/TestTraceLoad.py
  lldb/test/API/commands/trace/TestTraceSchema.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88841.297075.patch
Type: text/x-patch
Size: 63352 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201008/7792c40d/attachment-0001.bin>