[Lldb-commits] [PATCH] D88967: [lldb] Add a cmake warning about the python/swig incompatibility

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 8 09:13:20 PDT 2020


labath added a comment.

In D88967#2317851 <https://reviews.llvm.org/D88967#2317851>, @amccarth wrote:

> In D88967#2317545 <https://reviews.llvm.org/D88967#2317545>, @labath wrote:
>
>> In D88967#2317522 <https://reviews.llvm.org/D88967#2317522>, @amccarth wrote:
>>
>>> If I recall correctly, the non-debug builds still had the problem, they just didn't have the assertion that made it obvious.
>>
>> Is that problem only theoretical (like, "you shouldn't be doing that") or does it have some practical consequences (crashes, incorrect operation, etc.)?
>
> My memory isn't that detailed.  I think it was an argument being passed in as a single value but being referenced as though it was an array or list.  Or vice versa.

If we're talking about the same thing then it's about passing `None` instead of an empty list/dictionary. And it seems this is benign because the way python checks for emptyness also returns zero for `None` values.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88967/new/

https://reviews.llvm.org/D88967



More information about the lldb-commits mailing list