[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

[walter erquinigo via Phabricator via lldb-commits]

wallace updated this revision to Diff 296866.
wallace edited the summary of this revision.
wallace added a comment.

Addressed comments, which includse:

- Implemented the requested repeat command logic, including tests

- Now showing the total number of instructions as part of the dump command, which is something like

  thread #1: tid = 3842849, total instructions = 1000 instruction 0 instruction 1 instruction 2 ...

- Moved some logic to the parent diff D88841 <https://reviews.llvm.org/D88841>, leaving this diff simpler.

Some notes:

- In my current design, TraceProcess will be shared by all trace plug-ins when loading json trace sessions. For live processes, we'll simply use the actual Process instance used by the process, which means that most of the trace logic regarding processes will end up being in the base Process.
- In my next diff I'll include the trace decoding functionality, which will remove the placeholder text printed when invoking the dump command.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88769/new/

https://reviews.llvm.org/D88769

Files:
  lldb/include/lldb/Target/Target.h
  lldb/include/lldb/Target/Thread.h
  lldb/include/lldb/Target/Trace.h
  lldb/source/Commands/CommandObjectThread.cpp
  lldb/source/Commands/Options.td
  lldb/source/Plugins/Process/CMakeLists.txt
  lldb/source/Plugins/Process/Trace/CMakeLists.txt
  lldb/source/Plugins/Process/Trace/ProcessTrace.cpp
  lldb/source/Plugins/Process/Trace/ProcessTrace.h
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSessionFileParser.cpp
  lldb/source/Target/Target.cpp
  lldb/source/Target/Thread.cpp
  lldb/test/API/commands/trace/TestTraceDumpInstructions.py
  lldb/test/API/commands/trace/TestTraceLoad.py
  lldb/test/API/commands/trace/intelpt-trace/trace_2threads.json

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88769.296866.patch
Type: text/x-patch
Size: 27501 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201008/e0d0a0b8/attachment-0001.bin>