[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

Wed Oct 7 02:20:56 PDT 2020

teemperor added a reviewer: JDevlieghere.
teemperor added a comment.

LLDB_REVISION and LLDB_REPOSITORY are coming from VCSVersion.inc where it should be defined as a string. However the generation of that file seems to be broken since the monorepo migration. I put up a patch here that gets this working again: D88950 <https://reviews.llvm.org/D88950>

There is also the framework script that tries to define LLDB_REVISION but I assume that's only used for the headers we ship in the Framework? Not 100% sure what's going on with that.

Beside that, I think this code can really use some cleanup. I added some comments what else can be removed/updated.

================
Comment at: lldb/source/lldb.cpp:20

 static const char *GetLLDBRevision() {
 #ifdef LLDB_REVISION
----------------
This can return a string.

================
Comment at: lldb/source/lldb.cpp:29
 const char *lldb_private::GetVersion() {
   // On platforms other than Darwin, report a version number in the same style
   // as the clang tool.
----------------
You can remove that comment too, it's from a time where there was special Darwin version code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88939/new/

https://reviews.llvm.org/D88939