[Lldb-commits] [PATCH] D88866: [lldb] Add another fallback to GetXcodeSDK

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:378
+  auto xcrun = [](std::string sdk,
+                  std::string developer_dir = "") -> std::string {
+    std::string xcrun_cmd = "xcrun --show-sdk-path --sdk " + sdk;
----------------
In theory we could make this a StringRef and then have one less copy. Not important though.


================
Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:423
+            XcodeSDK::FindXcodeContentsDirectoryInPath(fspec.GetPath());
+        std::string shlib_developer_dir =
+            std::string(llvm::sys::path::parent_path(contents_dir));
----------------
 std::string shlib_developer_dir(...); ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88866/new/

https://reviews.llvm.org/D88866