[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

[António Afonso via Phabricator via lldb-commits]

aadsm added inline comments.


================
Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:36
 
 bool lldb_private::InferiorCallMmap(Process *process, addr_t &allocated_addr,
                                     addr_t addr, addr_t length, unsigned prot,
----------------
clayborg wrote:
> Might be nice to return a llvm::Error here instead of pool? Maybe to help explain what went wrong? like any of:
> 
> "thread required to call mmap"
> "couldn't find any symbols named 'mmap'"
> "no external symbols named 'mmap' were found"
> "mmap call failed" (for when it returns UINT32_MAX for 4 byte addresses or UINT64_MAX for 8 byte addresses"
> 
> It have been nice to see a nice error message during the expression evaluation prior to this fix. At the very least we should log to the expression log channel that mmap failed if we choose not to return an error.
I'd prefer to make this part of another diff and focus this one on the fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87868/new/

https://reviews.llvm.org/D87868