[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

Tue Oct 6 08:40:56 PDT 2020

labath added a comment.

In D88840#2314587 <https://reviews.llvm.org/D88840#2314587>, @rupprecht wrote:

> In D88840#2313331 <https://reviews.llvm.org/D88840#2313331>, @kastiglione wrote:
>
>> About `-P`, the man page for `lldb` and the driver's `Options.td` say it:
>>
>>> Prints out the path to the lldb.py file for this version of lldb.
>>
>> Should it do just that? If so this can be simplified further.
>
> It can print the path, or it can print `<COULD NOT FIND PATH>` if e.g. lldb wasn't built with python support or has some non-standard python setup. So I think this is basically as simple as the parsing can get.

One way this could be simplified further is to ditch `-P` and pass down the appropriate value from cmake/lit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88840/new/

https://reviews.llvm.org/D88840