[Lldb-commits] [PATCH] D88866: [lldb] Add another fallback to GetXcodeSDK

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

So this is adding a fallback that ignores DEVELOPER_DIR if it is set, but doesn't exist? Is that really desirable, or am I misunderstanding the patch? I would expect LLDB to fail hard if the DEVELOPER_DIR in the environment is wrong and not silently ignore it...



================
Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:389
 
     // Convert to a StringRef so we can manipulate the string without modifying
     // the underlying data.
----------------
Can we delete this comment? I find it more confusing than helpful...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88866/new/

https://reviews.llvm.org/D88866