[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

[Dave Lee via Phabricator via lldb-commits]

kastiglione added inline comments.


================
Comment at: lldb/test/API/types/TestRecursiveTypes.py:54
+        self.expect("print tpi")
+        self.expect("print *tpi")
----------------
aprantl wrote:
> I'm not not sure I understand this change?
The second parameter, `msg`, is only valid if there are other "matchers", like `substrs` or `startstr`. If not, then the `msg` isn't used and so shouldn't need to be passed. By preventing a `msg` here, it allows the precondition to distinguish between cases where the `msg` is valid, and where it's not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88792/new/

https://reviews.llvm.org/D88792