[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

Mon Oct 5 05:06:21 PDT 2020

labath added a comment.

Before going into the code details, could you give a high-level overview of the intended interactions between the Trace and ProcessTrace classes?

I am thinking about how to organize this so that we don't have too many criss-cross dependencies. My main question is whether it's expected that each "trace" plugin will also create its own ProcessTrace subclass.

================
Comment at: lldb/source/Target/TraceSettingsParser.cpp:13

-#include "Plugins/Process/Utility/HistoryThread.h"
+#include "Plugins/Process/Trace/ThreadTrace.h"
 #include "lldb/Core/Debugger.h"
----------------
This is a layering violation. We shouldn't have non-plugin code depend on plugin code. (I know there are some existing usages like that, but let's not add new ones -- people have been working for a long time to remove these.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88769/new/

https://reviews.llvm.org/D88769