[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

[Michał Górny via Phabricator via lldb-commits]

mgorny marked an inline comment as done.
mgorny added a comment.

Indeed I've been wondering how we could dedupe this. At least large part of hw watchpoint handling should be reusable.



================
Comment at: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:274
+  if (!IsHost()) {
+    printf("pare\n");
+    return PlatformPOSIX::DebugProcess(launch_info, debugger, target, error);
----------------
labath wrote:
> ?
Nów everyone knows I've been doing printf debugging! 


================
Comment at: lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:82
 void ProcessFreeBSD::Initialize() {
-  static llvm::once_flag g_once_flag;
+  if (!getenv("FREEBSD_REMOTE_PLUGIN")) {
+    static llvm::once_flag g_once_flag;
----------------
labath wrote:
> I would expect that the check above is sufficient, is it not?
Could you be more specific? I'm pretty sure I had to do this or otherwise the old plugin ended up being used. This is also how windows does it. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88796/new/

https://reviews.llvm.org/D88796