[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 15 09:16:10 PDT 2020


JDevlieghere added a comment.

In D86996#2273445 <https://reviews.llvm.org/D86996#2273445>, @labath wrote:

> This looks fine (sorry about the delay, I've been OOO).

I hope you had a good time. Glad to have you back! :-)



================
Comment at: lldb/test/Shell/ScriptInterpreter/Lua/lua.test:2
 # REQUIRES: lua
-# RUN: %lldb --script-language lua -o 'script print(1000+100+10+1)' 2>&1 | FileCheck %s
+# RUN: %lldb --script-language lua -o 'script -- io.stdout:write(1000+100+10+1, "\n")' 2>&1 | FileCheck %s
+# RUN: %lldb --script-language lua -o 'script --language default -- io.stdout:write(1000+100+10+1, "\n")' 2>&1 | FileCheck %s
----------------
labath wrote:
> Did you add the `--` here just for consistency? It believe it should not be necessary to use the double dash if the script command has no arguments (similar to how its possible to write `expr 1+2` without any dashes (but `expr -A -- 1+2` does require it)
I think I meant to have both but updated the line without copying it first. I'll fix that before landing. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86996/new/

https://reviews.llvm.org/D86996



More information about the lldb-commits mailing list