[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This looks fine (sorry about the delay, I've been OOO).



================
Comment at: lldb/test/Shell/ScriptInterpreter/Lua/lua.test:2
 # REQUIRES: lua
-# RUN: %lldb --script-language lua -o 'script print(1000+100+10+1)' 2>&1 | FileCheck %s
+# RUN: %lldb --script-language lua -o 'script -- io.stdout:write(1000+100+10+1, "\n")' 2>&1 | FileCheck %s
+# RUN: %lldb --script-language lua -o 'script --language default -- io.stdout:write(1000+100+10+1, "\n")' 2>&1 | FileCheck %s
----------------
Did you add the `--` here just for consistency? It believe it should not be necessary to use the double dash if the script command has no arguments (similar to how its possible to write `expr 1+2` without any dashes (but `expr -A -- 1+2` does require it)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86996/new/

https://reviews.llvm.org/D86996