[Lldb-commits] [PATCH] D87491: [lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI

[Med Ismail Bennani via Phabricator via lldb-commits]

mib marked an inline comment as done.
mib added inline comments.


================
Comment at: lldb/test/API/functionalities/breakpoint/serialize/TestBreakpointSerialization.py:77
+        self.assertEqual(serialized_data["Breakpoint"]["BKPTResolver"]["Options"]["FileName"], "foo")
+        self.assertEqual(serialized_data["Breakpoint"]["BKPTResolver"]["Options"]["LineNumber"], 42)
+
----------------
DavidSpickett wrote:
> How many other fields does a breakpoint contain? Might be worth adding one test showing the full result.
> 
> Unless Breakpoint::SerializeToStructuredData already has test coverage, just want to check that new fields don't get missed from this output.
This feature exists since 2016 and has been used to export breakpoints to a file using the `breakpoint write` command. If you look at the rest of the test file, the API is pretty well tested. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87491/new/

https://reviews.llvm.org/D87491