[Lldb-commits] [PATCH] D87491: [lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/test/API/functionalities/breakpoint/serialize/TestBreakpointSerialization.py:77
+        self.assertEqual(serialized_data["Breakpoint"]["BKPTResolver"]["Options"]["FileName"], "foo")
+        self.assertEqual(serialized_data["Breakpoint"]["BKPTResolver"]["Options"]["LineNumber"], 42)
+
----------------
How many other fields does a breakpoint contain? Might be worth adding one test showing the full result.

Unless Breakpoint::SerializeToStructuredData already has test coverage, just want to check that new fields don't get missed from this output.


================
Comment at: lldb/test/API/functionalities/breakpoint/serialize/TestBreakpointSerialization.py:88
+
+
     def setup_targets_and_cleanup(self):
----------------
Can you also check what happens if you serialize an invalid breakpoint?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87491/new/

https://reviews.llvm.org/D87491