[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D87333#2262260 <https://reviews.llvm.org/D87333#2262260>, @rupprecht wrote:

> In D87333#2262241 <https://reviews.llvm.org/D87333#2262241>, @clayborg wrote:
>
>> In D87333#2262236 <https://reviews.llvm.org/D87333#2262236>, @rupprecht wrote:
>>
>>> In D87333#2262229 <https://reviews.llvm.org/D87333#2262229>, @clayborg wrote:
>>>
>>>> FYI: we switched away from "localhost" a long time ago due to issues with people having a "localhost" entry in their /etc/hosts folder.
>>>
>>> I assume you mean people *not* having a "localhost" entry?
>>
>> I believe the issue was with people having a modified version that replaces localhost with some other IP address.
>>
>>> I didn't even realize that was an option. Yes, this patch would break that. I'll have to take another approach, then.
>>
>> You might check the "git log" on any files that have "127.0.0.1" in them for details.
>>
>>> Do you happen to have any references (bugs etc.) for those kinds of issues?
>
> Looks like rLLDB202424 <https://reviews.llvm.org/rLLDB202424> is the patch that did most of this. There may be more context in rdar://problem/16154630 but I don't have access to that.

Not a lot of context in that radar. Greg wrote:

> Anyone who was able to previously reproduce this issue by having DNS lookups on "localhost" take more than 3 seconds should no longer see this issue because we are now using "127.0.0.1" which will just get parsed as 4 numbers, not as a "lookup this name in a DNS registry".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87333/new/

https://reviews.llvm.org/D87333