[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

I have to agree with @kastiglione that this isn't very intuitive. I doubt that more than a handful of users are aware that "raw commands" are a thing, so I think this inconsistency is for once in favor of the user. LLDB commands are anyway not meant to be stable, so we can just fix this if this ever turns out to be a real issue.

Having said that, I think this shouldn't be done here but in its own patch with a less ad hoc implementation and some dedicated parsing tests. Good thing the command parsing implementation is so great, so that will be lots of fun for @JDevlieghere



================
Comment at: lldb/source/Commands/CommandObjectScript.cpp:99
+  } else {
+    // When no code is provided We want to be able to launch the interactive
+    // script interpreter without having to require the -- after the language.
----------------
`We` -> `we`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86996/new/

https://reviews.llvm.org/D86996