[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

[Dave Lee via Phabricator via lldb-commits]

kastiglione added a comment.

> Given the `expr` status quo, I'd stick with that.

I want to give a +1 to //not// copying `expr`. I think the tradeoff is not not worth it. My user perspective is that lldb could be improved by making more decisions with the user in mind, not lldb's engineers (to give some context). At this time, there's only `-l`/`--language` and I don't think the cases of ambiguity have enough likelihood to force the use of `--`.

Taking `--language` as an example, it's only valid python if `language` is a defined variable, and once you consider that it takes an argument, it becomes invalid in python (`--language python` or `--language=python`). For Lua, I can't think of practical cases for evaluating a comment, unless Lua uses comments for semantics/metaprogramming?. The common case of `-l <language> <code>` is not valid for either python or Lua.

I think it's a practical tradeoff to not require `--` at this point. Will there be more flags added, I don't know, but if there are I also think it's not a major problem to require `--` at a later time if the balances shift.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86996/new/

https://reviews.llvm.org/D86996