[Lldb-commits] [lldb] f9ad112 - [lldb] Speed up TestValueObjectRecursion by making it a no_debug_info_test

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 4 02:28:56 PDT 2020


Author: Raphael Isemann
Date: 2020-09-04T11:25:43+02:00
New Revision: f9ad112770ece2e3612ddcdd6a4157bc0b0faf31

URL: https://github.com/llvm/llvm-project/commit/f9ad112770ece2e3612ddcdd6a4157bc0b0faf31
DIFF: https://github.com/llvm/llvm-project/commit/f9ad112770ece2e3612ddcdd6a4157bc0b0faf31.diff

LOG: [lldb] Speed up TestValueObjectRecursion by making it a no_debug_info_test

This is one of the most expensive tests and runs for nearly half a minute on
my machine. Beside this test just doing a lot of work by iterating 15k times on
one ValueObject (which seems to be the point), it also runs this for every
debug info variant which doesn't seem relevant to just iterating ValueObject.

This marks it as no_debug_info_test to only run one debug info variation
and cut down the runtime to around 7 seconds on my machine.

Added: 
    

Modified: 
    lldb/test/API/functionalities/recursion/TestValueObjectRecursion.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/recursion/TestValueObjectRecursion.py b/lldb/test/API/functionalities/recursion/TestValueObjectRecursion.py
index e949f1a1a07e..1653fe36af7b 100644
--- a/lldb/test/API/functionalities/recursion/TestValueObjectRecursion.py
+++ b/lldb/test/API/functionalities/recursion/TestValueObjectRecursion.py
@@ -6,6 +6,7 @@
 
 
 import lldb
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 import lldbsuite.test.lldbutil as lldbutil
 
@@ -20,6 +21,7 @@ def setUp(self):
         # Find the line number to break at.
         self.line = line_number('main.cpp', '// Set break point at this line.')
 
+    @no_debug_info_test
     def test_with_run_command(self):
         """Test that deeply nested ValueObjects still work."""
         self.build()


        


More information about the lldb-commits mailing list