[Lldb-commits] [lldb] bdc4c0b - Revert "[lldb] avoid assert in threadsanitizer tests on linux"

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 4 00:32:13 PDT 2020


Author: Raphael Isemann
Date: 2020-09-04T09:30:56+02:00
New Revision: bdc4c0bc5c5e522aa770363fa6f50a3d5a5eadc2

URL: https://github.com/llvm/llvm-project/commit/bdc4c0bc5c5e522aa770363fa6f50a3d5a5eadc2
DIFF: https://github.com/llvm/llvm-project/commit/bdc4c0bc5c5e522aa770363fa6f50a3d5a5eadc2.diff

LOG: Revert "[lldb] avoid assert in threadsanitizer tests on linux"

This reverts commit f369d51896e1c0f61df253b116c42771479549df. The bug this
fixes was already fixed by 1c5a0cb1c3bffdae0d73acf8a23e31646b35c596 with the
same approach and this commit is now just giving the variable a second fallback
value.

Added: 
    

Modified: 
    lldb/source/Plugins/InstrumentationRuntime/TSan/InstrumentationRuntimeTSan.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/InstrumentationRuntime/TSan/InstrumentationRuntimeTSan.cpp b/lldb/source/Plugins/InstrumentationRuntime/TSan/InstrumentationRuntimeTSan.cpp
index 68e732538158..a2954f556b10 100644
--- a/lldb/source/Plugins/InstrumentationRuntime/TSan/InstrumentationRuntimeTSan.cpp
+++ b/lldb/source/Plugins/InstrumentationRuntime/TSan/InstrumentationRuntimeTSan.cpp
@@ -855,8 +855,6 @@ bool InstrumentationRuntimeTSan::NotifyBreakpointHit(
         });
     report->GetAsDictionary()->AddBooleanItem("all_addresses_are_same",
                                               all_addresses_are_same);
-  } else {
-    stop_reason_description = "unknown ThreadSanitizer stop reason";
   }
 
   // Make sure this is the right process


        


More information about the lldb-commits mailing list