[Lldb-commits] [PATCH] D86292: [LLDB][RISCV] Distinguish between riscv32 and riscv64 based on ELF class
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Aug 20 14:46:48 PDT 2020
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Patch looks good. Just need to test 32 bit RISC as well with a "lldb/test/Shell/ObjectFile/ELF/riscv32-arch.yaml" to verify 32 bit is working.
Comment at: lldb/test/Shell/ObjectFile/ELF/riscv64-arch.yaml:1-11
+# RUN: yaml2obj %s > %t
+# RUN: lldb-test object-file %t | FileCheck %s
+# CHECK: Architecture: riscv64--
We should test 32 bit as well right? Or do we already have one?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits