[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

[António Afonso via Phabricator via lldb-commits]

aadsm added inline comments.


================
Comment at: lldb/bindings/python/python-typemaps.swig:500
+  }
+};
+
----------------
lawrence_danna wrote:
> lawrence_danna wrote:
> > aadsm wrote:
> > > labath wrote:
> > > > Could you also `= delete` the copy operations to make sure nothing funny happens with those.
> > > The `= delete` is unsupported in SWIG 2, only in 3: http://www.swig.org/Doc3.0/CPlusPlus11.html#CPlusPlus11_defaulted_deleted
> > > Do we really need it, or is there a workaround it, or should we just bump the minimum requirements to SWIG 3?
> > It shouldn't be strictly necessary.  I put it in so if for some reason one of these values gets copied, it would result in a compiler error instead of a crash.
> This type could also just be moved into a header so swig doesn't need to parse it.
ah nice, of course, I can do this. thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77480/new/

https://reviews.llvm.org/D77480