[Lldb-commits] [lldb] 57e0ef1 - [lldb] Make it a fatal error when %lldb cannot be substituted

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2020-08-21T11:18:21-07:00
New Revision: 57e0ef131b621dc88ad2db53a52bf86b498e49c3

URL: https://github.com/llvm/llvm-project/commit/57e0ef131b621dc88ad2db53a52bf86b498e49c3
DIFF: https://github.com/llvm/llvm-project/commit/57e0ef131b621dc88ad2db53a52bf86b498e49c3.diff

LOG: [lldb] Make it a fatal error when %lldb cannot be substituted

Refuse to run the shell tests when %lldb cannot be substituted. This
prevents the test from silently running again the `lldb` in your PATH.

I noticed because when this happens, %lldb-init gets substituted with
lldb-init, which does not exists.

Added: 
    

Modified: 
    lldb/test/Shell/helper/toolchain.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/Shell/helper/toolchain.py b/lldb/test/Shell/helper/toolchain.py
index 64a0c6671516..2b075d5523d4 100644
--- a/lldb/test/Shell/helper/toolchain.py
+++ b/lldb/test/Shell/helper/toolchain.py
@@ -48,10 +48,12 @@ def use_lldb_substitutions(config):
     primary_tools = [
         ToolSubst('%lldb',
                   command=FindTool('lldb'),
-                  extra_args=['--no-lldbinit', '-S', lldb_init]),
+                  extra_args=['--no-lldbinit', '-S', lldb_init],
+                  unresolved='fatal'),
         ToolSubst('%lldb-init',
                   command=FindTool('lldb'),
-                  extra_args=['-S', lldb_init]),
+                  extra_args=['-S', lldb_init],
+                  unresolved='fatal'),
         ToolSubst('%debugserver',
                   command=FindTool(dsname),
                   extra_args=dsargs,