[Lldb-commits] [lldb] 2ddba09 - [lldb] Set the launch flags to GetLaunchInfo().GetLaunchFlags()

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2020-08-13T10:24:35-07:00
New Revision: 2ddba09e067add1910cc0f39ce9e1e4e0e43bb28

URL: https://github.com/llvm/llvm-project/commit/2ddba09e067add1910cc0f39ce9e1e4e0e43bb28
DIFF: https://github.com/llvm/llvm-project/commit/2ddba09e067add1910cc0f39ce9e1e4e0e43bb28.diff

LOG: [lldb] Set the launch flags to GetLaunchInfo().GetLaunchFlags()

Instead of clearing the launch flags, always pass the target's current
launch flags.

Added: 
    

Modified: 
    lldb/test/API/commands/expression/expr-in-syscall/TestExpressionInSyscall.py
    lldb/test/API/commands/register/register/register_command/TestRegisters.py
    lldb/test/API/functionalities/target-new-solib-notifications/TestModuleLoadedNotifys.py
    lldb/test/API/python_api/event/TestEvents.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/expression/expr-in-syscall/TestExpressionInSyscall.py b/lldb/test/API/commands/expression/expr-in-syscall/TestExpressionInSyscall.py
index 458a1476b4498..7b5db6c454348 100644
--- a/lldb/test/API/commands/expression/expr-in-syscall/TestExpressionInSyscall.py
+++ b/lldb/test/API/commands/expression/expr-in-syscall/TestExpressionInSyscall.py
@@ -31,6 +31,7 @@ def expr_syscall(self):
         # launch the inferior and don't wait for it to stop
         self.dbg.SetAsync(True)
         error = lldb.SBError()
+        flags = target.GetLaunchInfo().GetLaunchFlags()
         process = target.Launch(listener,
                                 None,      # argv
                                 None,      # envp
@@ -38,7 +39,7 @@ def expr_syscall(self):
                                 None,      # stdout_path
                                 None,      # stderr_path
                                 None,      # working directory
-                                0,         # launch flags
+                                flags,     # launch flags
                                 False,     # Stop at entry
                                 error)     # error
 

diff  --git a/lldb/test/API/commands/register/register/register_command/TestRegisters.py b/lldb/test/API/commands/register/register/register_command/TestRegisters.py
index 9441483816c5f..1712e58841435 100644
--- a/lldb/test/API/commands/register/register/register_command/TestRegisters.py
+++ b/lldb/test/API/commands/register/register/register_command/TestRegisters.py
@@ -284,13 +284,14 @@ def fp_register_write(self):
 
         # Launch the process, stop at the entry point.
         error = lldb.SBError()
+        flags = target.GetLaunchInfo().GetLaunchFlags()
         process = target.Launch(
                 lldb.SBListener(),
                 None, None, # argv, envp
                 None, None, None, # stdin/out/err
                 self.get_process_working_directory(),
-                0, # launch flags
-                True, # stop at entry
+                flags, # launch flags
+                True,  # stop at entry
                 error)
         self.assertSuccess(error, "Launch succeeds")
 

diff  --git a/lldb/test/API/functionalities/target-new-solib-notifications/TestModuleLoadedNotifys.py b/lldb/test/API/functionalities/target-new-solib-notifications/TestModuleLoadedNotifys.py
index 8c5ebd8897599..e03c6abfda068 100644
--- a/lldb/test/API/functionalities/target-new-solib-notifications/TestModuleLoadedNotifys.py
+++ b/lldb/test/API/functionalities/target-new-solib-notifications/TestModuleLoadedNotifys.py
@@ -52,7 +52,7 @@ def test_launch_notifications(self):
             True
 
         error = lldb.SBError()
-        flags = lldb.eLaunchFlagInheritTCCFromParent
+        flags = target.GetLaunchInfo().GetLaunchFlags()
         process = target.Launch(listener,
                                 None,      # argv
                                 None,      # envp

diff  --git a/lldb/test/API/python_api/event/TestEvents.py b/lldb/test/API/python_api/event/TestEvents.py
index 62ed195729f00..c8100ca7efab8 100644
--- a/lldb/test/API/python_api/event/TestEvents.py
+++ b/lldb/test/API/python_api/event/TestEvents.py
@@ -50,6 +50,7 @@ def test_listen_for_and_print_event(self):
 
         # Now launch the process, and do not stop at the entry point.
         error = lldb.SBError()
+        flags = target.GetLaunchInfo().GetLaunchFlags()
         process = target.Launch(listener,
                                 None,      # argv
                                 None,      # envp
@@ -57,7 +58,7 @@ def test_listen_for_and_print_event(self):
                                 None,      # stdout_path
                                 None,      # stderr_path
                                 None,      # working directory
-                                0,         # launch flags
+                                flags,     # launch flags
                                 False,     # Stop at entry
                                 error)     # error
 
@@ -145,6 +146,7 @@ def test_wait_for_event(self):
 
         # Now launch the process, and do not stop at entry point.
         error = lldb.SBError()
+        flags = target.GetLaunchInfo().GetLaunchFlags()
         process = target.Launch(listener,
                                 None,      # argv
                                 None,      # envp
@@ -152,7 +154,7 @@ def test_wait_for_event(self):
                                 None,      # stdout_path
                                 None,      # stderr_path
                                 None,      # working directory
-                                0,         # launch flags
+                                flags,     # launch flags
                                 False,     # Stop at entry
                                 error)     # error
         self.assertTrue(error.Success() and process, PROCESS_IS_VALID)
@@ -224,6 +226,7 @@ def test_add_listener_to_broadcaster(self):
 
         # Now launch the process, and do not stop at the entry point.
         error = lldb.SBError()
+        flags = target.GetLaunchInfo().GetLaunchFlags()
         process = target.Launch(listener,
                                 None,      # argv
                                 None,      # envp
@@ -231,7 +234,7 @@ def test_add_listener_to_broadcaster(self):
                                 None,      # stdout_path
                                 None,      # stderr_path
                                 None,      # working directory
-                                0,         # launch flags
+                                flags,     # launch flags
                                 False,     # Stop at entry
                                 error)     # error