[Lldb-commits] [PATCH] D85904: [lldb] Check Decl kind when completing -flimit-debug-info types

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

Is it too late to claim that I did this on purpose to see if anyone noticed the bug? It probably is :/



================
Comment at: lldb/test/API/functionalities/limit-debug-info/main.cpp:31
 
+struct ShadowedOne : public func_shadow::One {
+  constexpr ShadowedOne() = default;
----------------
Nit: the `public` isn't necessary and you also omitted above.


================
Comment at: lldb/test/API/functionalities/limit-debug-info/main.cpp:32
+struct ShadowedOne : public func_shadow::One {
+  constexpr ShadowedOne() = default;
+  int member = 47;
----------------
I'm probably missing something obvious here, but why give every class in the test a defaulted constexpr constructor?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85904/new/

https://reviews.llvm.org/D85904