[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

Thu Aug 13 05:45:45 PDT 2020

labath accepted this revision.
labath added a comment.

This looks good to me. I appreciate the efforts taken to reduce the test size.

The trick for controlling the debug info order is neat, and I may end up using it some time. FWIW, the way I usually handle these things is by first replacing all constant debug info offsets with symbolic references (`.long 123` -> `.long .Lmytype-.debug_info`). After that, it's possible to freely manipulate any debug info entry. (At that point I usually delete all DW_AT_decl_file/lines and other boring attributes, which tends to reduce the file a lot).

================
Comment at: lldb/test/Shell/SymbolFile/DWARF/valueobject-pass-by-reg.s:1
+# RUN: llvm-mc -filetype=obj -o %t -triple x86_64-apple-macosx10.15.0 %s
+# RUN: %lldb %t -o "target variable ug" -b | FileCheck %s
----------------
I don't think the test file name matches what is being tested anymore. Maybe name it something like `DW_AT_data_bit_offset-DW_OP_stack_value` (in line with other tests in this folder)?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85376/new/

https://reviews.llvm.org/D85376