[Lldb-commits] [PATCH] D85758: [lldb] Make several attempts to read the PID in TestAppleSimulatorOSType

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 11 10:52:41 PDT 2020


aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/test/API/tools/lldb-server/TestAppleSimulatorOSType.py:66
+        for _ in range(0, self.PID_RETRIES):
             stderr = sim_launcher.stderr.readline().decode("utf-8")
+            if not stderr:
----------------
I'm not sure I would call this RETRIES since we're just reading more lines from stderr. May MAX_LINES?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85758/new/

https://reviews.llvm.org/D85758



More information about the lldb-commits mailing list