[Lldb-commits] [PATCH] D85275: [RFC/WIP] Fix the assumption that m_arguments in ProcessInfo does not include arg0

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I agree this should be cleaned up.

I don't have any strong opinions on how this should work. IIUC, this patch goes in direction of making m_args always not contain argv[0]. That is probably fine -- if nothing else, it makes the class match the lldb settings (which have argv[0] as a separate entity). But maybe matching the settings is not the most important thing, and I can see how making argv[0] a part of the args array could simplify other things...

In any case, we should add some unit tests for the ProcessInfo class which demonstrates how these apis are supposed to work.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85275/new/

https://reviews.llvm.org/D85275