[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

The idea is fine -- the same logic is used in `Symbols::LocateExecutableSymbolFile`. In fact, one of the problems of our pdb support is that it does not use that function to locate symbol files (that way it would also respect the `target.debug-file-search-paths` setting, which it looks like it doesn't do right now). But it can't do that right now, because we don't treat pdbs as `ObjectFile`s, etc..

This doesn't seem particularly intrusive, so I don't think we need to teach introduce an ObjectFilePDB just yet, but I think a time will come when we will need to do that...

This could use a test though. It sounds like it shouldn't be hard to construct one (?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84815/new/

https://reviews.llvm.org/D84815