[Lldb-commits] [PATCH] D84791: [intel-pt] Fix python support and add a full python test

walter erquinigo via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 28 12:46:15 PDT 2020


wallace added inline comments.


================
Comment at: lldb/source/API/SBDebugger.cpp:66-69
+  std::string error_message;
   llvm::sys::DynamicLibrary dynlib =
-      llvm::sys::DynamicLibrary::getPermanentLibrary(spec.GetPath().c_str());
+      llvm::sys::DynamicLibrary::getPermanentLibrary(spec.GetPath().c_str(),
+                                                     &error_message);
----------------
I'm adding this small change, which helped a lot to figure out some issues when loading the intel plugin shared object. I hope you don't mind.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84791/new/

https://reviews.llvm.org/D84791



More information about the lldb-commits mailing list