[Lldb-commits] [PATCH] D84791: [intel-pt] Fix python support and add a full python test

walter erquinigo via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 28 12:44:20 PDT 2020


wallace created this revision.
wallace added reviewers: clayborg, labath.
Herald added subscribers: lldb-commits, mgorny.
Herald added a project: LLDB.
wallace requested review of this revision.

The initial implementation of the Intel PT support for LLDB came with
some Python support. However, when LLDB was upgraded to more modern versions of
SWIG and Python3, the Intel Pt Python API broke and has not been updated since
then.
This makes me believe that no one has used that API in a looong time.

As a fix, I replicated some fixes done in the core LLDB Python support.
Additionally, I added a test that uses entirely the Intel PT Python API and made
some additional fixes to the existing test.

I'm not fond of the existing API design, so I'll be improving it in following
diffs.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84791

Files:
  lldb/source/API/SBDebugger.cpp
  lldb/test/API/tools/intel-features/intel-pt/test/TestIntelPTSimpleBinary.py
  lldb/tools/intel-features/CMakeLists.txt
  lldb/tools/intel-features/scripts/CMakeLists.txt
  lldb/tools/intel-features/scripts/lldb-intel-features.swig

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84791.281333.patch
Type: text/x-patch
Size: 10500 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200728/9443dfcd/attachment.bin>


More information about the lldb-commits mailing list