[Lldb-commits] [PATCH] D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo

Frederic Riss via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 27 17:19:23 PDT 2020


friss marked an inline comment as done.
friss added inline comments.


================
Comment at: lldb/unittests/Utility/ArchSpecTest.cpp:329
     ASSERT_FALSE(A.IsExactMatch(B));
     // FIXME: See above, though the extra environment complicates things.
     ASSERT_FALSE(A.IsCompatibleMatch(B));
----------------
aprantl wrote:
> What's to fix here?
Aren't you the one who introduced this comment? I can move my new test one slot up so it makes this a little less confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84716/new/

https://reviews.llvm.org/D84716





More information about the lldb-commits mailing list